tools: apply feedback to and simplify contributor guidance workflow - #65785
Open
panva wants to merge 5 commits into
Open
tools: apply feedback to and simplify contributor guidance workflow#65785panva wants to merge 5 commits into
panva wants to merge 5 commits into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
the
meta
panva
commented
Sep 4, 2026
aduh95
reviewed
Sep 4, 2026
panva
added
the
commit-queue-squash
Signed-off-by: Filip Skokan <[email protected]>
panva
force-pushed
the
contributor-guidance-follow-up
branch
2 times, most recently
from
September 4, 2026 14:01
600a8fe to
d9f687b
Compare
panva
marked this pull request as ready for review
September 4, 2026 14:46
panva
removed
the
commit-queue-squash
aduh95
approved these changes
Sep 5, 2026
aduh95
left a comment
aduh95
left a comment
Contributor
There was a problem hiding this comment.
A nice-to-have would be to also check which base branch the PR is targeting in case it's not main, but that can be a follow-up – or not, after all it's arguably a rare enough occurrence
panva
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying feedback from #65745 (review) and, assuming contributor-guidance.yml runs confirm it's not necessary, removing and resolving its TODO.
This is also a place to apply further feedback collected from observing the action actually run.
Investigate: